-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix main composer shows briefly when opening emoji picker #41298
Fix main composer shows briefly when opening emoji picker #41298
Conversation
@@ -450,7 +450,7 @@ function ReportActionItemMessageEdit( | |||
setIsFocused(false); | |||
// @ts-expect-error TODO: TextInputFocusEventData doesn't contain relatedTarget. | |||
const relatedTargetId = event.nativeEvent?.relatedTarget?.id; | |||
if (relatedTargetId && [messageEditInput, emojiButtonID].includes(relatedTargetId)) { | |||
if ((relatedTargetId && [messageEditInput, emojiButtonID].includes(relatedTargetId)) || EmojiPickerAction.isEmojiPickerVisible()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to use isEmojiPickerVisible
instead so it can detect when the emoji picker is opened from another edit composer.
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemweb-chrome.moviOS: Nativeios.moviOS: mWeb Safarimweb-safari.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀
|
Details
When an edit composer is blurred, we want to show the main composer back, but there are some cases where we want to ignore that, such as it's blurred because we open an emoji picker of an edit composer.
Fixed Issues
$ #40461
PROPOSAL: #40461 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
mWeb/Android/iOS
For web/desktop, the main composer won't hide, so, just ignore steps 4, 6, 8
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-04-30.at.11.59.16.mov
Android: mWeb Chrome
Screen.Recording.2024-04-30.at.12.00.08.mov
iOS: Native
Screen.Recording.2024-04-30.at.11.59.01.mov
iOS: mWeb Safari
Screen.Recording.2024-04-30.at.11.58.28.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-30.at.12.02.52.mov
MacOS: Desktop
Screen.Recording.2024-04-30.at.12.03.43.mov